Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shopware): add nginx to container for aws environment #14

Merged

Conversation

joerivanveen
Copy link
Contributor

No description provided.

@joerivanveen joerivanveen force-pushed the feat/shopware/add-nginx-to-container-for-aws-environment branch 2 times, most recently from cfe9d04 to 8e4641c Compare August 15, 2024 14:28
@joerivanveen joerivanveen force-pushed the feat/shopware/add-nginx-to-container-for-aws-environment branch from 4746bf5 to f057d30 Compare October 24, 2024 15:05
@joerivanveen joerivanveen marked this pull request as ready for review October 28, 2024 13:06
Copy link

gitguardian bot commented Oct 28, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11399378 Triggered Generic Database Assignment becbb78 images/shopware/.env.template View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@myparcel-bot myparcel-bot bot force-pushed the feat/shopware/add-nginx-to-container-for-aws-environment branch from 693d587 to becbb78 Compare October 30, 2024 10:05
@myparcel-bot myparcel-bot bot added the approved label Nov 7, 2024
@FreekVR FreekVR self-requested a review November 8, 2024 12:11
@joerivanveen joerivanveen merged commit 37d42e0 into main Nov 8, 2024
5 checks passed
@joerivanveen joerivanveen deleted the feat/shopware/add-nginx-to-container-for-aws-environment branch November 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants